Skip to content

Add DNS servers from cellular PDP to nsapi #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2019
Merged

Add DNS servers from cellular PDP to nsapi #11162

merged 2 commits into from
Aug 7, 2019

Conversation

@AriParkkila
Copy link

@AriParkkila AriParkkila commented Aug 5, 2019

Description

Add DNS servers from PDP contexts to nsapi_dns. Also fix nsapi_dns_add_server to add each server just once.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kivaisan

Release Notes

kivaisan
kivaisan suggested changes Aug 5, 2019
View reviewed changes
@ciarmcom ciarmcom requested review from a team and kivaisan August 5, 2019 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 5, 2019

@AriParkkila, thank you for your changes.
@kivaisan @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@AriParkkila
Copy link
Author

AriParkkila commented Aug 5, 2019

@kivaisan Please re-review.

@mbed-ci
Copy link

mbed-ci commented Aug 5, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@AriParkkila
Copy link
Author

AriParkkila commented Aug 6, 2019

Fixed unittests, ready for merge.

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 976c30c into ARMmbed:master Aug 7, 2019
@0xc0170 0xc0170 mentioned this pull request Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@kivaisan kivaisan kivaisan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.13.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AriParkkila @ciarmcom @mbed-ci @SeppoTakalo @kivaisan